Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add scheme option for url type validation #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FEATURE] Add scheme option for url type validation #122

wants to merge 1 commit into from

Conversation

blakegearin
Copy link

API Changes

  • Added passive scheme option to augment type: 'url' validation
  • Added unit tests

Notes

@blakegearin
Copy link
Author

This has been open for almost a year with no feedback. Should this be closed, updated, or merged?

cc @snewcomer @SergeAstapov

@SergeAstapov
Copy link
Contributor

@blakegearin looks good to me, although I don't have access to this repo.

@rwwagner90 maybe able to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blakegearin @SergeAstapov