Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failed testcase name in tap file #367

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Nov 11, 2022

Related adoptium/aqa-tests#4146

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo
Copy link
Contributor Author

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert
Copy link
Contributor

I like this, thanks @sophia-guo ! I will leave the 2nd / final review for @renfeiw (as Lan has explicitly asked for it).

On the topic of adding additional information to the TAP files, separate from this work (and not expected to be covered by this PR), I was recently wondering if we could also include the line of jtreg output that summarized the total testcases in the target.

Test results: passed: 39; failed: 21

my $failureTests = "";
foreach my $line (@lines)
{
if ( $line =~ /TEST: /) {
Copy link
Contributor

@renfeiw renfeiw Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to match the 50 hyphens before and then the TEST:

11:44:10  --------------------------------------------------
11:44:12  TEST: java/util/stream/test/org/openjdk/tests/java/util/stream/FilterOpTest.java

This could be more reliable compared to only TEST:. In an extreme case, if we have not only openjdk but also other folders in the buildlist, TEST: is too general.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Trying with multiple line query doesn't work well ( works in my local environment and failed with builds). Decided just using the simple loop, which works and feels simple and straightforward.

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo
Copy link
Contributor Author

Grinder in Eclipse temurin https://ci.eclipse.org/temurin-compliance/job/Grinder/2221/

Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants