-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thank you box should not include bots #474
Comments
Seeing multiple times where the thank you box is not being populated on a page load. I suspect that if the random page selected only has one contributor (a bot) then the current fix loops forever, so should choose another random page and contributor if a bot was initially selected. |
Ahh yes, some wonky coding from me there, I guess we need to add a second check and break the while loop once we have an acceptable contributor |
if the selected contributor is a bot, just pick an entirely new page and try again. It's random, not fair :-) |
* fix: only show real contributor in Thank You box Ref: #474 * feat: add do-while till fine non-bot user
I think this can be closed, it doesn't seem to be an issue anymore |
The Adoptium website thanks contributors by showing a box at the bottom of each page.
This thank you randomly selects a contributor from various project repositories, however, it currently includes automated bot "contributions".
The code should be updated to ignore known bots from the thank-you (by selecting a new contributor who is not in a list of known bots).
The text was updated successfully, but these errors were encountered: