Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank you box should not include bots #474

Closed
tellison opened this issue May 6, 2022 · 8 comments · Fixed by #476
Closed

Thank you box should not include bots #474

tellison opened this issue May 6, 2022 · 8 comments · Fixed by #476
Labels
good first issue Good for newcomers

Comments

@tellison
Copy link
Contributor

tellison commented May 6, 2022

The Adoptium website thanks contributors by showing a box at the bottom of each page.

This thank you randomly selects a contributor from various project repositories, however, it currently includes automated bot "contributions".

The code should be updated to ignore known bots from the thank-you (by selecting a new contributor who is not in a list of known bots).

@tellison tellison added the good first issue Good for newcomers label May 6, 2022
@tellison
Copy link
Contributor Author

tellison commented May 6, 2022

Screenshot 2022-05-06 20 57 41

@tellison
Copy link
Contributor Author

tellison commented May 6, 2022

Screenshot 2022-05-06 21 00 06

@tellison
Copy link
Contributor Author

tellison commented May 6, 2022

Screenshot 2022-05-06 21 02 53

... you get the idea :-)

@tellison
Copy link
Contributor Author

Seeing multiple times where the thank you box is not being populated on a page load.

I suspect that if the random page selected only has one contributor (a bot) then the current fix loops forever, so should choose another random page and contributor if a bot was initially selected.

@gdams
Copy link
Member

gdams commented May 11, 2022

Ahh yes, some wonky coding from me there, I guess we need to add a second check and break the while loop once we have an acceptable contributor

@tellison
Copy link
Contributor Author

if the selected contributor is a bot, just pick an entirely new page and try again. It's random, not fair :-)

zdtsw added a commit to zdtsw/website-v2 that referenced this issue Jun 17, 2022
zdtsw added a commit to zdtsw/website-v2 that referenced this issue Jul 6, 2022
@smlambert smlambert added this to To do in Good First Issues via automation Aug 4, 2022
karianna pushed a commit that referenced this issue Aug 31, 2022
* fix: only show real contributor in Thank You box

Ref: #474

* feat: add do-while till fine non-bot user
@hendrikebbers
Copy link
Contributor

@zdtsw @gdams can we close this issue?

@gdams
Copy link
Member

gdams commented May 26, 2023

I think this can be closed, it doesn't seem to be an issue anymore

@gdams gdams closed this as completed May 26, 2023
Good First Issues automation moved this from To do to Done May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
3 participants