Download page should be robust to misuse

[tellison]

The download page expects a parameter to ensure the correct download is initiated. When that parameter is not available, likely by the user directly accessing the page, it currently prints out an "oops" message, but it would be more helpful where there is no location provided to redirect the user to the latest releases page (likely using navigate and replace history).

The "oops" error can be retained for internal problems resolving the location link.

[belfarz]

hello I'm Hassan Suleiman an outreachy applicant and i would love to work on this

[belfarz]

hello, I'm finding it hard to work on the issue as i am not sure what i'm supposed to do, if you don't mind putting me through

…

On Sun, 9 Oct 2022 at 22:45, Shelley Lambert ***@***.***> wrote: Assigned #519 <#519> to @belfarz <https://github.com/belfarz>. — Reply to this email directly, view it on GitHub <#519 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3OGLH3QYCON4XBOAM43FYDWCM4IBANCNFSM5VYZQMAQ> . You are receiving this because you were assigned.Message ID: ***@***.***>

[karianna]

I've updated the links in Tim's original message above so you'll be able to go through to the source code. You'll see that the error message gets printed on line 63 because the location parameter wasn't passed in. Instead of that error message we'd like users to be redirected to the latest releases page.

You should be able to checkout the whole site locally and test it there.

[belfarz]

okay so i should add a link to the latest release pages when user clicks on the link in line 62

[karianna]

Correct, but only if that link has no location request parameter

[Chealer]

This is not merely about misuse. Google web search (and surely others) links to that page, which suffices to get

Ooops - something doesn't seem quite right here. Please try again.

I also obtained this error by clicking on the ".msi" link from the Latest Releases page on Google Chrome 111.0.5563.
The proper behavior relies on event handlers, which must have been absent when I first clicked. Presumably, some transient bug on the Latest releases page which I can't reproduce must have prevented the relevant event handler from being bound.

Please retitle this to:

Download page: "Ooops - something doesn't seem quite right here." error