Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adoptium-1643] Download page lack checksum info #2125

Conversation

xavierfacq
Copy link
Member

Description of change

This pull request is to fix the lack of checksum info on the download page reported in issue #1643

What it looks like:
image

Checklist

  • npm test passes

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit ffa0f06
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/64e336dfb23ae7000753e7e9
😎 Deploy Preview https://deploy-preview-2125--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #2125 (ffa0f06) into main (f1a6ee8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2125   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          85       85           
  Lines        6270     6293   +23     
  Branches      535      536    +1     
=======================================
+ Hits         6218     6241   +23     
  Misses         52       52           
Files Changed Coverage Δ
src/components/LatestTemurin/index.tsx 81.37% <100.00%> (-0.19%) ⬇️
src/components/MarketplaceDownloadTable/index.tsx 100.00% <100.00%> (ø)
src/components/TemurinArchiveTable/index.tsx 100.00% <100.00%> (ø)
src/components/TemurinDownloadTable/index.tsx 100.00% <100.00%> (ø)
src/components/TemurinNightlyTable/index.tsx 100.00% <100.00%> (ø)
src/hooks/fetchLatestTemurin.tsx 100.00% <100.00%> (ø)
src/pages/download.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xavierfacq xavierfacq marked this pull request as ready for review August 21, 2023 10:22
@hendrikebbers
Copy link
Contributor

That looks really good :) If @gdams has no comment on the JS code - I'm a JS noob :D - we should merge it.

@gdams gdams merged commit ae99b9b into adoptium:main Aug 24, 2023
13 checks passed
@gdams gdams linked an issue Aug 24, 2023 that may be closed by this pull request
@xavierfacq xavierfacq deleted the fix/adoptium-1643_download_page_lack_checksum_info branch September 7, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download page lacks checksum info
3 participants