-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[adoptium-510] Marketplace vendor selector should randomise order #2131
[adoptium-510] Marketplace vendor selector should randomise order #2131
Conversation
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2131 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 85 85
Lines 6274 6283 +9
Branches 534 536 +2
=======================================
+ Hits 6222 6231 +9
Misses 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This doesn't seem to be working for me. Try refreshing the page and the values get muddled up |
Ok, if you do F5 or ctrl+shift+r does it work ? Nevermind, I'll use another solution to have a good refresh. EDIT: i think we have the same problem with the members page |
@gdams if you can, plz test this new version, it changes every time, using useState and useEffect. There is a small resize, but I think there are problems with scss not well reloaded. I'll investigate this point, on another branch. 🙏 |
Are you seeing entries in the table with this change? Table is empty for me. |
@tellison can you give me your navigator / OS, and if you have an error in your console ? I have pushed a small CSS fixe, few minutes ago, but I don't think it is the problem. |
I don't understand why the last preview do not reflect what I have done... Like if there is a cache... here : https://deploy-preview-2131--eclipsefdn-adoptium.netlify.app/marketplace/ |
Yes, Netlify does cache static content on deploy preview - I've come across that before. I don't remember how to clear it manually. I think I asked @gdams to do it last time. |
I wonder if your problem could be more a problem with the download table than the randomised vendors 🤔... You don't have the problem with the online version? |
Correct - I don't see the same problem with the live site. Thanks for investigating! |
@tellison I found the problem, and it's good now. My default list of vendors was empty to avoid the "refresh" and view the randomization. I tried another way, but it remains something strange with the page that does full refreshs. I keep the PR as draft to test another thing. Let me known if it's OK for you the behavior with MacOs |
Initial display is now populated again for me. 👍 |
Description of change
This PR is related to the issue #510
I suggest to have the same behavior like in 'Members':
Checklist
npm test
passes