[adoptium.net-1508] Release notes should initially be sorted by priority & component #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2181 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 87 87
Lines 6420 6440 +20
Branches 539 544 +5
=======================================
+ Hits 6368 6388 +20
Misses 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@xavierfacq Can we get the code coverage back up for this change in terms of tests? |
gdams
reviewed
Sep 4, 2023
gdams
reviewed
Sep 4, 2023
Co-authored-by: George Adams <george.adams@microsoft.com>
gdams
approved these changes
Sep 4, 2023
xavierfacq
deleted the
feature/release_notes_should_initially_be_by_priority_then_component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR is a small improvement for the point 4 of the issue #1508
Release notes are now initially sorted by priority & component.
I have also reduced sort type to ASC et DESC (no more "null" order!)
Note that reversing the order by priority (DESC) do not reverse the order of the "component" column.
A good test is : https://deploy-preview-2181--eclipsefdn-adoptium.netlify.app/fr/temurin/release-notes/?version=jdk-17.0.8+7
Checklist
npm testpasses