Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support build metadata containing a variant of 'temurin' #341

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Support build metadata containing a variant of 'temurin' #341

merged 1 commit into from
Mar 9, 2022

Conversation

johnoliver
Copy link
Contributor

Checklist

  • You added tests to cover the change
  • mvn clean install build and test completes
  • You changed or added to the documentation

@johnoliver johnoliver requested a review from sxa March 9, 2022 15:06
@sxa sxa mentioned this pull request Mar 9, 2022
Closed
sxa
sxa approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other option would be to get the JSON to include hotspot instead of temurin during a VARIANT=temurin build, but this would also work and potentially be more "correct" so I'm good with this.

@jerboaa
Copy link
Contributor

jerboaa commented Mar 9, 2022

@johnoliver is this fixing #331 ?

@johnoliver
Copy link
Contributor Author

@jerboaa yes, sorry, should have tagged that issue

@jerboaa jerboaa linked an issue Mar 9, 2022 that may be closed by this pull request
Latest Nightly builds no longer showing #331
Closed
@karianna karianna merged commit 9b76cf2 into adoptium:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tellison tellison tellison approved these changes

@sxa sxa sxa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest Nightly builds no longer showing
5 participants
@johnoliver @jerboaa @tellison @sxa @karianna