Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TEST_ARGS to make test command #11

Closed
helenmasters opened this issue Sep 28, 2017 · 3 comments
Closed

Add TEST_ARGS to make test command #11

helenmasters opened this issue Sep 28, 2017 · 3 comments
Assignees

Comments

@helenmasters
Copy link
Contributor

Currently when running e.g. make test.JdiLoadTest I can't specify an individual test to run e.g. simple_launch. To do that I have to go right down to the perl layer underneath.

As I'm trying to investigate a failure in one test within the test suite adding this feature would make it easier to reproduce failures, as we could then allow the launching of single tests through jenkins directly. In effect I'm requesting the addition of TEST_ARGS="test=basic_launch" or something similar to the makefile.

@lumpfish lumpfish self-assigned this Sep 28, 2017
@lumpfish
Copy link
Contributor

I'll add a test.Custom target in openjdk.build/makefile which one can then use as:
make test.Custom TEST=JdiTest TEST_ARGS="test=basic_launch" JAVA_ARGS="-Xint"
(TEST would be required, the other macros optional unless the TEST requires a -test-arg argument).

To enable execution on an AdoptOpenJDK test machine via Jenkins we will need a Jenkins job which allows a user to supply those macros via Parameters.

lumpfish pushed a commit to lumpfish/aqa-systemtest that referenced this issue Sep 28, 2017
Signed-off-by: Simon Rushton <rushton@uk.ibm.com>
helenmasters added a commit that referenced this issue Sep 28, 2017
Add test.Custom target to openjdk.build/maklefile - issue #11
@helenmasters
Copy link
Contributor Author

This is now merged and working, hence closing.

@lumpfish
Copy link
Contributor

See #13 for enabling running the new test target on an AdoptOpenJDK test machine from Jenkins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants