Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up branch pat #84

Merged
merged 15 commits into from
Apr 30, 2019
Merged

Cleaned up branch pat #84

merged 15 commits into from
Apr 30, 2019

Conversation

Yuehan-Lin
Copy link
Contributor

No description provided.

Karim Guirguis and others added 14 commits January 25, 2019 14:10
update getBuildHistory endpoint

Signed-off-by: ADAM Natale <adam.natale@ibm.com>
…c on one graph and Add checkboxes for turning off and on specific platforms

Signed-off-by: Adam Natale <adam.natale@ibm.com>
Signed-off-by: Adam Natale <adam.natale@ibm.com>
Signed-off-by: Adam Natale <adam.natale@ibm.com>
Signed-off-by: Adam Natale <adam.natale@ibm.com>
Signed-off-by: Adam Natale <adam.natale@ibm.com>
Signed-off-by: Adam Natale <adam.natale@ibm.com>
Signed-off-by: Adam Natale <adam.natale@ibm.com>
…e baseline to 7k for ODM

Signed-off-by: Adam Natale <adam.natale@ibm.com>
Signed-off-by: Adam Natale <adam.natale@ibm.com>
Signed-off-by: Adam Natale <adam.natale@ibm.com>
@Yuehan-Lin Yuehan-Lin changed the title Cleaned up branch pat [WIP] Cleaned up branch pat Apr 4, 2019
@karianna karianna added this to In progress in aqa-test-tools via automation Apr 4, 2019
@karianna karianna added the bug Something isn't working label Apr 4, 2019
Copy link
Contributor

@piyush286 piyush286 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be good to delay these changes until we can get this feature done: Aggregate Perf Results From Multiple Benchmark Iterations. That might be a more appropriate time to clean and merge these changes.

Earlier, we didn't have the interleave feature for PerfNext, and hence, we had to use an arbitrary number to represent the baseline.

https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/7e2faf7f6b3d26b2102ddcab4bd0cf5f89cc26a9/test-result-summary-client/src/Dashboard/Widgets/Graph/ODM.jsx#L27

Also, we'll need to add appropriate logic to use the correct baselines for different platforms. Most of those things would need to be covered in the Tabular Views for Comparing Baseline and Test Builds for Selected Platforms & Metrics feature, which is a higher priority issue than Jumpstart features.

@llxia
Copy link
Contributor

llxia commented Apr 12, 2019

Talked with @piyush286 , the main concern is that we do not want to wait too long for merging pat branch as the code diverges may result impossible to merge in the future. This PR is only for porting pat into master and simple code clean up. Any additional enhancement can be added once this PR is merged.

Signed-off-by: Yuehan-Lin <Yuehan.Lin@ibm.com>
@Yuehan-Lin Yuehan-Lin changed the title [WIP] Cleaned up branch pat Cleaned up branch pat Apr 17, 2019
aqa-test-tools automation moved this from In progress to Reviewer approved Apr 30, 2019
@llxia llxia merged commit 1421cd6 into adoptium:master Apr 30, 2019
aqa-test-tools automation moved this from Reviewer approved to Done Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants