Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate java/math/BigInteger/largeMemory/SymmetricRangeTests.java when fixed at openjdk #1687

Closed
lumpfish opened this issue Mar 19, 2020 · 5 comments
Assignees
Labels
Milestone

Comments

@lumpfish
Copy link
Contributor

This should be kept open until https://bugs.openjdk.java.net/browse/JDK-8241097 is fixed.

The test java/math/BigInteger/largeMemory/SymmetricRangeTests.java needs reinstating to run on openj9 releases when the required test change described in https://bugs.openjdk.java.net/browse/JDK-8241097 is made.

@karianna karianna added the bug label Mar 19, 2020
@smlambert
Copy link
Contributor

We do not actually want to keep duplicate issues or "reinstate" issues open in this repo. Once an issue is raised to the appropriate repo where a fix needs to take place, we should update the excludes file with its URL and close the openjdk-tests one.

It is sufficient to ensure that the excludes file references URL to the upstream defect.

Right now those excludes links get manually checked, but the reason we insist on the full URL is used, is that we have the eventual intention to automate the reinclusion, based on the the state of the linked issue and whether an automated rerun of the test passes.

So, https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/openjdk/ProblemList_openjdk14-openj9.txt#L150 can be updated to point to https://bugs.openjdk.java.net/browse/JDK-8241097 instead of the now closed openj9 bug, and https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/openjdk/ProblemList_openjdk14-openj9.txt#L152 should be removed (as its a duplicate entry to line 150) at which point this issue should be closed.

I believe there are some other issues in this repo that can be similarly closed (where there is an upstream bug reported, exclude file updated to point to the real issue and openjdk-tests issue closed).

@lumpfish
Copy link
Contributor Author

OK, I've created #1689.
I've pointed all releases at the same issue url for now because there are not yet any issues for backporting the test fix to releases other than HEAD.

@karianna karianna added this to the March 2020 milestone Mar 19, 2020
@karianna
Copy link
Contributor

@lumpfish merged that PR, can we close this?

@lumpfish
Copy link
Contributor Author

Yes, closing

@smlambert
Copy link
Contributor

Thanks @lumpfish !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants