Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerBasicTest.java run fail on aarch64 platform #3629

Closed
sendaoYan opened this issue May 6, 2022 · 11 comments · Fixed by #3885
Closed

DockerBasicTest.java run fail on aarch64 platform #3629

sendaoYan opened this issue May 6, 2022 · 11 comments · Fixed by #3885
Assignees
Labels
JBS issue need to report to JBS or reopen the issue in JBS

Comments

@sendaoYan
Copy link
Contributor

Describe the bug
DockerBasicTest.java run fail on aarch64 platform, because of can't get the "aarch64/ubuntu:latest" docker image.

To Reproduce
jtreg -va -nr -w tmp hotspot/test/runtime/containers/docker/DockerBasicTest.java

docker pull aarch64/ubuntu:latest

Expected behavior
run success

Screenshots

image

image

image

Additional context
dockerfile generate by testcase:

image

hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerfileConfig.java:

image

git diff hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerfileConfig.java 
diff --git a/hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerfileConfig.java b/hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerfileConfig.java
index e000f0eed4..f8d424a3a1 100644
--- a/hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerfileConfig.java
+++ b/hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerfileConfig.java
@@ -44,7 +44,7 @@ public class DockerfileConfig {
 
         switch (Platform.getOsArch()) {
             case "aarch64":
-                return "aarch64/ubuntu";
+                return "ubuntu";
             case "ppc64le":
                 return "ppc64le/ubuntu";
             case "s390x":
@sophia-guo
Copy link
Contributor

Test passed in grinder https://ci.adoptopenjdk.net/job/Grinder/4604/console, which is using temurin jdk8 aarch64. Not sure the real reason for the failure.

@sendaoYan
Copy link
Contributor Author

Test passed in grinder https://ci.adoptopenjdk.net/job/Grinder/4604/console, which is using temurin jdk8 aarch64. Not sure the real reason for the failure.

If you want to run this test really, you should make sure the docker service work normally.
Testcase will check docker service before test start.

image

image

@sendaoYan
Copy link
Contributor Author

testcase list:

runtime/containers/docker/DockerBasicTest.java
runtime/containers/docker/TestCPUAwareness.java
runtime/containers/docker/TestCPUSets.java
runtime/containers/docker/TestMemoryAwareness.java
runtime/containers/docker/TestMisc.java

@smlambert smlambert added the JBS issue need to report to JBS or reopen the issue in JBS label Jul 25, 2022
sendaoYan added a commit to sendaoYan/aqa-tests that referenced this issue Jul 26, 2022
Excluded docker testcases on linux-aarch64: DockerBasicTest.java TestCPUAwareness.java TestCPUSets.java TestMemoryAwareness.java TestMisc.java

Fixes: adoptium#3629
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
llxia pushed a commit that referenced this issue Jul 26, 2022
Excluded docker testcases on linux-aarch64: DockerBasicTest.java TestCPUAwareness.java TestCPUSets.java TestMemoryAwareness.java TestMisc.java

Fixes: #3629
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@sophia-guo
Copy link
Contributor

@sendaoYan Could you confirm that we need to open an issue in JBS to update hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerfileConfig.java to fix this issue?

@sendaoYan
Copy link
Contributor Author

@sendaoYan Could you confirm that we need to open an issue in JBS to update hotspot/test/testlibrary/com/oracle/java/testlibrary/DockerfileConfig.java to fix this issue?

I think it's necessaty to creat open an issue in upstream JBS. But I don't have an account.
After this issue has been fixed, we can enable these testcase again.

@sophia-guo
Copy link
Contributor

@andrew-m-leonard could you help this? Reopen and will close when issue is opened in jbs

@sophia-guo sophia-guo reopened this Jul 28, 2022
@sophia-guo
Copy link
Contributor

Same issue with arm32 https://ci.adoptopenjdk.net/job/Grinder/5314/

sophia-guo pushed a commit to sophia-guo/openjdk-tests that referenced this issue Jul 29, 2022
Excluded docker testcases on linux-aarch64: DockerBasicTest.java TestCPUAwareness.java TestCPUSets.java TestMemoryAwareness.java TestMisc.java

Fixes: adoptium#3629
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
smlambert pushed a commit that referenced this issue Jul 29, 2022
* Excluded docker testcases on linux-aarch64 platform (#3885)

Excluded docker testcases on linux-aarch64: DockerBasicTest.java TestCPUAwareness.java TestCPUSets.java TestMemoryAwareness.java TestMisc.java

Fixes: #3629
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>

* Disable TestMemoryAwareness.java (#3891)

Disable runtime/containers/docker/TestMemoryAwareness.java, which fail because of kernel does not support swap limit capabilities or the cgroup is not mounted

Fixes: #3886
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>

* July release: update problem list for jdk8, especially arm (#3898)

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>

Co-authored-by: yansendao <yansendao.ysd@alibaba-inc.com>
@andrew-m-leonard
Copy link
Contributor

What is the correct fix here? removing aarch64 from the docker image name doesn't look right to me?

@jerboaa
Copy link
Contributor

jerboaa commented Nov 14, 2022

The correct fix for this is to specify -Djdk.test.docker.image.name=<base-image-name> and -Djdk.test.docker.image.version=<image-version> when running the test. That is, if you wanted to run the test on a registry.fedoraproject.org/fedora:37 base image, one would set:

-Djdk.test.docker.image.name=registry.fedoraproject.org/fedora \
-Djdk.test.docker.image.version=37

It's not a good idea to rely on the defaults for those container tests.

@jerboaa
Copy link
Contributor

jerboaa commented Nov 14, 2022

There really is nothing to report upstream, as that's the way to handle mismatches on the base image versions. See https://bugs.openjdk.org/browse/JDK-8221342

@sendaoYan
Copy link
Contributor Author

jdk.test.docker.image.name

Thanks for your advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JBS issue need to report to JBS or reopen the issue in JBS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants