Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun build with failed targets has an unnecessary extra space in front of comma #4063

Closed
smlambert opened this issue Oct 20, 2022 · 7 comments
Assignees

Comments

@smlambert
Copy link
Contributor

TARGET parameter is populated with the list of failed targets and there is an unneeded space inserted, see this example:

testList TESTLIST=jdk_nio_0 ,jdk_imageio_0 ,jdk_net_0 ,jdk_security3_0 ,jdk_security3_1 ,jdk_tools_1 ,jdk_imageio_1

We should determine where this extra space is coming from and remove the extra space, see the code that generates the link in the addFailedTestsGrinderLink method of the Jenkinsfilebase file

@Nuel-Eneji
Copy link
Contributor

Greetings @smlambert, I have completed my first issue, can i please work on this?
Thanks

@Nuel-Eneji
Copy link
Contributor

Salutations, @smlambert I hope everything is good with you. I appreciate you giving me this assignment.
I kindly ask for assistance in setting up and executing the tests on my personal computer. I followed the instructions here but I was unable to move past the process. I need assistance conducting the tests, please. Thanks

@smlambert
Copy link
Contributor Author

hi @Nuel-Eneji - those instructions are out-of-date. For Jenkinsfile changes, the reviewers will run some tests on your branch or draft PR on our Jenkins server, or I can temporarily enable you to do so and together we can assess whether it resolves the problem or needs more adjustments. Once you have some changes pushed to a draft PR, we can start to test it. I am guessing for this issue, it is a matter of applying "trim()" in the appropriate place.

@Nuel-Eneji
Copy link
Contributor

Hello, @smlambert I hope everything is good with you.
I just made a draft pull request #4074 as directed and used the trim() function where it was thought to be suitable.
I would like to take part in the PR review process.
Thanks

@Nuel-Eneji
Copy link
Contributor

Hello @smlambert Hope you're well?
Can you please make this task as done?
Thanks

@llxia
Copy link
Contributor

llxia commented Nov 2, 2022

Resolved via #4074

@llxia llxia closed this as completed Nov 2, 2022
@Nuel-Eneji
Copy link
Contributor

Thanks alot @llxia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants