-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rerun build with failed targets has an unnecessary extra space in front of comma #4063
Comments
Greetings @smlambert, I have completed my first issue, can i please work on this? |
Salutations, @smlambert I hope everything is good with you. I appreciate you giving me this assignment. |
hi @Nuel-Eneji - those instructions are out-of-date. For Jenkinsfile changes, the reviewers will run some tests on your branch or draft PR on our Jenkins server, or I can temporarily enable you to do so and together we can assess whether it resolves the problem or needs more adjustments. Once you have some changes pushed to a draft PR, we can start to test it. I am guessing for this issue, it is a matter of applying "trim()" in the appropriate place. |
Hello, @smlambert I hope everything is good with you. |
Hello @smlambert Hope you're well? |
Resolved via #4074 |
Thanks alot @llxia |
TARGET parameter is populated with the list of failed targets and there is an unneeded space inserted, see this example:
testList TESTLIST=jdk_nio_0 ,jdk_imageio_0 ,jdk_net_0 ,jdk_security3_0 ,jdk_security3_1 ,jdk_tools_1 ,jdk_imageio_1
We should determine where this extra space is coming from and remove the extra space, see the code that generates the link in the addFailedTestsGrinderLink method of the Jenkinsfilebase file
The text was updated successfully, but these errors were encountered: