Exclude java/util/WeakHashMap/GCDuringIteration.java #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlambert
reviewed
Dec 3, 2020
| @@ -261,6 +261,7 @@ java/util/stream/boottest/java.base/java/util/stream/NodeTest.java https://githu | |||
| java/util/stream/test/org/openjdk/tests/java/util/SplittableRandomTest.java https://github.com/eclipse/openj9/issues/4613 generic-all | |||
| java/util/stream/test/org/openjdk/tests/java/util/stream/CountLargeTest.java https://github.com/eclipse/openj9/issues/9040 linux-aarch64 | |||
| java/util/stream/test/org/openjdk/tests/java/util/stream/ToArrayOpTest.java https://github.com/eclipse/openj9/issues/3447 generic-all | |||
| java/util/WeakHashMap/GCDuringIteration.java https://github.com/eclipse/openj9/issues/10256 generic-all | |||
There was a problem hiding this comment.
Can you change the issue to point to #1297 (a placeholder for permanent excludes, openjdk tests that are not and will never be applicable to openj9) for the 3 entries in this PR? I will reference openj9/10256 in 1297.
When we add automation to reinclude tests by checking if issues in problemlists are closed, issue 1297 will be exempt, but other issues not.
Issue eclipse-openj9/openj9#10256 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
smlambert
approved these changes
Dec 3, 2020
|
Do not think our PR tests will verify this is excluded (as it currently is not a change-based check, related: #2072 (comment)), so merging ahead of the checks completing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue eclipse-openj9/openj9#10256
Signed-off-by: Peter Shipton Peter_Shipton@ca.ibm.com