Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude TestAESCipher tests that modify security permissions specific to hotspot #2156

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Exclude TestAESCipher tests that modify security permissions specific to hotspot #2156

merged 1 commit into from
Jan 12, 2021

Conversation

andrew-m-leonard
Copy link
Contributor

Excludes problem hotspot tests from: eclipse-openj9/openj9#11614

Signed-off-by: Andrew Leonard anleonar@redhat.com

@andrew-m-leonard
Copy link
Contributor Author

@smlambert
Copy link
Contributor

Thanks @andrew-m-leonard - Is the plan to make the fix in the extensions repo (as openj9/11614 suggests) or permanently exclude? If permanently exclude, we will use a openjdk-tests/1297 issue in the PR, if will fix under 11614 then can leave as is).

Is this also needed in later jdk versions, or just jdk8?

@sophia-guo
Copy link
Contributor

Looks like it's jdk8 only. And test need to be updated to work for openj9 or need to be excluded permanently.

@andrew-m-leonard
Copy link
Contributor Author

@smlambert I think Peter's view is to permanently exclude, so i'll update to point at #1297

… to hotspot

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Copy link
Contributor Author

@smlambert updated... and yes jdk8 only

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smlambert smlambert merged commit 68c5944 into adoptium:master Jan 12, 2021
@karianna karianna added this to TODO in aqa-tests via automation Jan 15, 2021
@karianna karianna added this to the January 2021 milestone Jan 15, 2021
@karianna karianna moved this from TODO to Done in aqa-tests Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
aqa-tests
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants