-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude SharedClasse softmx increase JitAot test from linux ppc64le #285
Exclude SharedClasse softmx increase JitAot test from linux ppc64le #285
Conversation
Signed-off-by: Mesbah <Mesbah_Alam@ca.ibm.com>
This exclusion is due to adoptium/aqa-systemtest#79 |
@@ -695,6 +695,7 @@ | |||
</impls> | |||
</test> | |||
|
|||
<!-- Exclude the following test on Linux ppc64le. Reason: AdoptOpenJDK/openjdk-systemtest/issues/79 --> | |||
<test> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the < disabled > tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Shelley, the test is only failing on ppc64le Linux. So, it's only excluded from running on that platform. This is achieved by the use of platformRequirements
tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, so the original test has been repurposed as the non-linux one, and a new test added for the linux platforms with ^ppcle for now.
Eventually when the defect is fixed, we drop back to only one entry for that test in the playlist (for all platforms).
This change could have been done with only one test entry, by just adding ^ppcle to the list? or you would then have to explicitly mention all platforms it could run on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if we just added ^ppc in the single test entry, then that'd exclude the test from ppc64 aix too, so in that case we would have had to explicitly mention each platform it runs on. Yes, once the test is fixed, we will remove the second entry of the test and also remove the platformRequirements
tag from the first entry.
Signed-off-by: Mesbah Mesbah_Alam@ca.ibm.com