Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable jtreg test selection by keywords #2890

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

sophia-guo
Copy link
Contributor

Enable jtreg test selection by keywords so jtreg can select tests automatically

Add keyword '!headful' so tests need ci won't run on headless jdk.

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo
Copy link
Contributor Author

sophia-guo commented Sep 21, 2021

@sophia-guo
Copy link
Contributor Author

Should we limit the selection to Temurin build? Do IBM or others want to test a headful alpine binary?

@smlambert
Copy link
Contributor

re: #2890 (comment) - IMHO, if someone wants to update this later if they are producing a full build for alpine-linux then it can come in as a separate PR. In PMC discussions, it was noted that in known cases, alpine-linux applications are headless, which lead us to the decision to produce headless (let's assume for now other distributors would be same, until we hear differently).

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sophia-guo !

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants