Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APPLICATION_OPTIONS as a test job parameter #4140

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

andrew-m-leonard
Copy link
Contributor

Adds a new APPLICATION_OPTIONS test job parameter which is used optionally by Jck and System to pass additional "test application" options.

Also fixed Jenkins result parsing of logMatcher() as it was failing with the disabled. as (DISABLED:) is not printed in that format.

Signed-off-by: Andrew Leonard anleonar@redhat.com

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Nov 10, 2022

Test Grinder for "System": https://ci.adoptopenjdk.net/view/work-in-progress/job/andrew_grinder/5/console
Test Grinder for "openjdk", should not be affected: https://ci.adoptopenjdk.net/view/work-in-progress/job/andrew_grinder/7/
Test Grinder for "System", with old job template, should default APPLICATION_OPTIONS: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6171/

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @andrew-m-leonard ! (and for including DISABLED into the log matcher, as the visibility of that one is valuable)

@andrew-m-leonard andrew-m-leonard self-assigned this Nov 10, 2022
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit 61b08e7 into adoptium:master Nov 11, 2022
@Mesbah-Alam
Copy link
Contributor

Mesbah-Alam commented Nov 11, 2022

Started a grinder with a random jck target for sanity check: Grinder_JCK/851 (passed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants