Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rerun failed jdk | hotspot testcases in Grinder with jdk_custom | hotspot_custom target #4284

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jan 27, 2023

close #4265

Signed-off-by: Sophia Guo sophia.gwf@gmail.com

@sophia-guo sophia-guo marked this pull request as draft January 27, 2023 22:57
@sophia-guo
Copy link
Contributor Author

Depends on adoptium/TKG#397 #4283

@sophia-guo sophia-guo self-assigned this Jan 30, 2023
@sophia-guo sophia-guo marked this pull request as ready for review January 30, 2023 19:15
@sophia-guo
Copy link
Contributor Author

@sophia-guo
Copy link
Contributor Author

@sophia-guo sophia-guo marked this pull request as ready for review January 31, 2023 00:03
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@smlambert
Copy link
Contributor

Parallel Grinder result does not capture all of the CUSTOM_TARGET values that are reported in TAP files:
https://ci.adoptopenjdk.net/job/Grinder/6532/tapResults/ shows that we would expect to see:

sun/security/lib/cacerts/VerifyCACerts.java
sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java
jdk/net/ExtendedSocketOption/DontFragmentTest.java
compiler/vectorapi/reshape/TestVectorCastNeon.java

But I only see compiler/vectorapi/reshape/TestVectorCastNeon.java from the new rerun link

@sophia-guo
Copy link
Contributor Author

There are two links - jdk_custom and hotspot_custom. Rerun failed jdk test cases in Grinder with jdk_custom target
Rerun failed hotspot test cases in Grinder with hotspot_custom target

That three tests belong to jdk group and are set in jdk_custom link.

@smlambert
Copy link
Contributor

Ah, thanks @sophia-guo, I should have paid more attention! Thanks for these Grinders!

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@llxia
Copy link
Contributor

llxia commented Feb 2, 2023

I should have tested this on openj9 and hyc Jenkins. I was too excited about the PR.

For the record, when using new Jenkins libraries/APIs, we need to test on all Jenkins to ensure the permission is set correctly. See eclipse-openj9/openj9#16649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Rerun in Grinder using jdk_custom | hotspot_custom with failed testcases'
3 participants