Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FFI/Jtreg]Exclude VaListTest in JDK20 #4489

Merged

Conversation

ChengJin01
Copy link
Contributor

The change exclude this test suite as we no longer need VaList
as specified in the latest JEP442 at
eclipse-openj9/openj9#16951

Fixes: eclipse-openj9/openj9/issues/17091

Signed-off-by: ChengJin01 jincheng@ca.ibm.com

@ChengJin01
Copy link
Contributor Author

Reviewer: @llxia
FYI: @ShelleyLambert, @tajila, @pshipton

@llxia
Copy link
Contributor

llxia commented Apr 3, 2023

@ChengJin01 Is this a permanent exclusion? If so, please add a comment in #1297 and update PR to reference #1297. Thanks

The change exclude this test suite as we no longer
need VaList as specified in the latest JEP442 at
eclipse-openj9/openj9#16951

Fixes: eclipse-openj9/openj9/issues/17091

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
@ChengJin01 ChengJin01 force-pushed the exclude_ffi_jtreg_valist_jdk20 branch from 578bb08 to b763053 Compare April 3, 2023 17:19
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ChengJin01

@ChengJin01
Copy link
Contributor Author

@ChengJin01 Is this a permanent exclusion? If so, please add a comment in #1297 and update PR to reference #1297. Thanks

Updated as suggested above (as there is no plan for OpenJDK to restore them back in the near future).

@karianna karianna merged commit 4f3f360 into adoptium:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JDK20/FFI_Jtreg] IndexOutOfBoundsException captured in VaListTest
3 participants