Enable test specified docker image in grinder #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llxia
reviewed
May 5, 2023
external/external.sh
Outdated
| do | ||
| restore_docker_image_name_list+=("${docker_registry_url}/$job_name/${JDK_VERSION}-${JDK_IMPL}-${docker_os}-${platform}-${image_os_micro_architecture}:${build_number}") | ||
| done | ||
| if [[ $job_name == "Grinder" ]]; then |
There was a problem hiding this comment.
job_name is a local variable. To make this simple, I think we should use $JOB_NAME directly and remove line 31
There was a problem hiding this comment.
The PR has been updated, and issue related to PingPerf has been opened, which will resolve in another PR. Thanks.
|
A similar change is needed for PingPerf. It can be in a separated PR. Eventually, we should merge the code for basic criu and PingPerf together. |
- for grinder portable restore test, only pull the specified docker image - for non-grinder pipeline, pull all available platfrom checkpoint images Signed-off-by: LongyuZhang <longyu.zhang@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grinder_imagePull, pull all available platfrom checkpoint imagesCloses criu-ubi-portable-checkpoint_test not able to test a specific checkpoint image #4561