Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable verbose GC log in openjdk tests #4873

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Enable verbose GC log in openjdk tests #4873

merged 1 commit into from
Nov 21, 2023

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Nov 17, 2023

-Prepended -Xverbosegclog to EXTRA_OPTIONS

closes: #4872

@annaibm annaibm force-pushed the enableVerboseGC_4872 branch 3 times, most recently from 711d42a to 6631872 Compare November 17, 2023 18:52
llxia
llxia reviewed Nov 20, 2023
View reviewed changes
openjdk/openjdk.mk Outdated Show resolved Hide resolved
@llxia
Copy link
Contributor

llxia commented Nov 20, 2023

This PR changes openjdk tests, so we need to run an openjdk test to verify (not functional test)

@annaibm annaibm force-pushed the enableVerboseGC_4872 branch 5 times, most recently from f95547f to 9109e80 Compare November 21, 2023 14:20
@annaibm
Copy link
Contributor Author

annaibm commented Nov 21, 2023 •
edited

Grinder tests:
1.https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36301/console
Check with ARCHIVE_TEST_RESULTS
2. https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36310/

@annaibm annaibm requested a review from llxia November 21, 2023 15:25
llxia
llxia reviewed Nov 21, 2023
View reviewed changes
openjdk/openjdk.mk Outdated Show resolved Hide resolved
@llxia
Copy link
Contributor

llxia commented Nov 21, 2023

Please use ARCHIVE_TEST_RESULTS to check if the log is archived properly. Thanks

llxia
llxia reviewed Nov 21, 2023
View reviewed changes
openjdk/openjdk.mk Outdated Show resolved Hide resolved
@annaibm
Copy link
Contributor Author

annaibm commented Nov 21, 2023 •
edited

Grinder result with ARCHIVE_TEST_RESULTS and KEEP_REPORTDIR=true
1.https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36319/
Grinder result when user specified EXTRA_OPTIONS: eg: -Xdump:java:events=vmstop is provided.
2.https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36320/console

@annaibm annaibm marked this pull request as ready for review November 21, 2023 17:54
@annaibm
Enable verbose GC log in openjdk tests
0e656b9 
-Prepend -Xverbosegclog for all operating systems
-Prepend when JDK_IMPL is openj9 or ibm

closes: adoptium#4872

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
llxia
llxia approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LongyuZhang
LongyuZhang approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 48d953f into adoptium:master Nov 21, 2023
1 check passed
annaibm added a commit to annaibm/aqa-tests that referenced this pull request Nov 21, 2023
@annaibm
Enable verbose GC log in openjdk tests (adoptium#4873)
cfdcbc8 
-Prepend -Xverbosegclog for all operating systems
-Prepend when JDK_IMPL is openj9 or ibm

closes: adoptium#4872

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm added a commit to annaibm/aqa-tests that referenced this pull request Nov 22, 2023
@annaibm
Enable verbose GC log in openjdk tests (adoptium#4873)
97ddd5c 
-Prepend -Xverbosegclog for all operating systems
-Prepend when JDK_IMPL is openj9 or ibm

closes: adoptium#4872

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm added a commit to annaibm/aqa-tests that referenced this pull request Nov 22, 2023
@annaibm
Exclude test for FIPS OpenJdk (adoptium#4876)
405eb54 
-Disables FIPS test for `jdk_security_infra`, `jdk_security1`, `jdk_security2`, `jdk_security3`
-Disable FIPS test for all platforms, on versions 8 and above

related: backlog/issues/1089

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
Co-authored-by: Kapil Anant Powar <kapilpowar17@gmail.com>

Enable verbose GC log in openjdk tests (adoptium#4873)

-Prepend -Xverbosegclog for all operating systems
-Prepend when JDK_IMPL is openj9 or ibm

closes: adoptium#4872

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
@pshipton pshipton mentioned this pull request Nov 22, 2023
Closed
pshipton added a commit to pshipton/openj9-openjdk-jdk17 that referenced this pull request Nov 22, 2023
@pshipton
Ignore verbosegc files in TestVersionedStream
0dda783 
Issue eclipse-openj9/openj9#18512
Related to adoptium/aqa-tests#4873

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton added a commit to pshipton/openj9-openjdk-jdk17 that referenced this pull request Nov 22, 2023
@pshipton
Ignore verbosegc files in TestVersionedStream
b3ac393 
Issue eclipse-openj9/openj9#18512
Related to adoptium/aqa-tests#4873

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
This was referenced Nov 22, 2023
Merged
Merged
pshipton added a commit to pshipton/openj9-openjdk-jdk that referenced this pull request Nov 22, 2023
@pshipton
Ignore verbosegc files in TestVersionedStream
6588bbf 
Issue eclipse-openj9/openj9#18512
Related to adoptium/aqa-tests#4873

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton added a commit to pshipton/openj9-openjdk-jdk21 that referenced this pull request Nov 22, 2023
@pshipton
Ignore verbosegc files in TestVersionedStream
94edb61 
Issue eclipse-openj9/openj9#18512
Related to adoptium/aqa-tests#4873

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton pshipton mentioned this pull request Nov 22, 2023
Merged
pshipton added a commit to pshipton/openj9-openjdk-jdk11 that referenced this pull request Nov 22, 2023
@pshipton
Ignore verbosegc files in TestVersionedStream
5912660 
Issue eclipse-openj9/openj9#18512
Related to adoptium/aqa-tests#4873

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton pshipton mentioned this pull request Nov 22, 2023
Merged
@annaibm annaibm deleted the enableVerboseGC_4872 branch November 23, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@LongyuZhang LongyuZhang LongyuZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable verbose GC log in openjdk tests
3 participants
@annaibm @llxia @LongyuZhang