Exclude CryptoTests for OpenJ9 FIPS #5003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re eclipse-openj9/openj9#18801 it should be excluded for FIPS mode only. |
|
eclipse-openj9/openj9#16712 is resolved, I wonder if the non-FIPS exclude should be removed for jdk19+. |
JasonFengJ9
force-pushed
the
excludecryptotests
branch
from
aa0c4db
to
5c3f414
Compare
JasonFengJ9
changed the title
JasonFengJ9
force-pushed
the
excludecryptotests
branch
from
5c3f414
to
7c3f08a
Compare
Enabled it. |
Disabled it via |
|
Pls try a jdk21 grinder on all platforms in order to re-enable CryptoTest in non-fips runs. |
pshipton
reviewed
Jan 25, 2024
JasonFengJ9
force-pushed
the
excludecryptotests
branch
from
7c3f08a
to
9a11b60
Compare
Signed-off-by: Jason Feng <fengj@ca.ibm.com>
JasonFengJ9
force-pushed
the
excludecryptotests
branch
from
9a11b60
to
7679f67
Compare
An internal grinder shows a few timeout errors. |
karianna
approved these changes
Jan 26, 2024
pshipton
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude
CryptoTestsfor OpenJ9 FIPSAn internal grinder
Related to eclipse-openj9/openj9#18801
Signed-off-by: Jason Feng fengj@ca.ibm.com