Permanently disable VThreadInHeapDump & GetStackTraceAndRetransformTest #5037
Conversation
For OpenJ9 JDK22+, the following tests are disabled: - VThreadInHeapDump relies upon -Xlog:heapdump which is unsupported in OpenJ9. - GetStackTraceAndRetransformTest utilizes the WhiteBox API, which is also unsupported in OpenJ9. Closes: eclipse-openj9/openj9#18809 Closes: eclipse-openj9/openj9#18811 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
| @@ -562,9 +562,9 @@ serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java https://githu | |||
| serviceability/jvmti/vthread/ToggleNotifyJvmtiTest/ToggleNotifyJvmtiTest.java https://github.com/adoptium/aqa-tests/issues/1297 generic-all | |||
| serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java#default https://github.com/eclipse-openj9/openj9/issues/18426 generic-all | |||
| serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java#no-vmcontinuations https://github.com/eclipse-openj9/openj9/issues/18426 generic-all | |||
| serviceability/jvmti/vthread/HeapDump/VThreadInHeapDump.java https://github.com/eclipse-openj9/openj9/issues/18811 generic-all | |||
| serviceability/jvmti/vthread/HeapDump/VThreadInHeapDump.java https://github.com/adoptium/aqa-tests/issues/1297 generic-all | |||
There was a problem hiding this comment.
I'd prefer these are excluded with a link to the openj9 issues so if someone is looking to see why they are excluded, the appropriate details are easily found.
There was a problem hiding this comment.
@ShelleyLambert had mentioned that there is a test script which automatically re-enables the tests once the linked issue is closed. Using #1297 prevents the script to re-enable the test once the corresponding OpenJ9 issue is closed. @llxia Is there a way to include the OpenJ9 issue in the exclude while permanently disabling tests?
There was a problem hiding this comment.
I've never seen that in action for OpenJ9 issues, so I'd be surprised if it's working. If we did use such a thing it should check for the "perm excluded" label.
There was a problem hiding this comment.
I can find examples of closed issues that have excluded tests. Here are a couple.
eclipse-openj9/openj9#16551
eclipse-openj9/openj9#15247
There was a problem hiding this comment.
yes, we have automation (disabled test pipeline) to auto re-enable tests based on referenced issues. However, we haven't enabled this check. For openj9, I think we should enhance the disabled test pipeline to check "perm excluded" label on the issue.
There was a problem hiding this comment.
For openj9, I think we should enhance the disabled test pipeline to check "perm excluded" label on the issue.
I have added the "perm excluded" label in eclipse-openj9/openj9#18809 and eclipse-openj9/openj9#18811. I am closing this PR since the automation check is currently disabled. Hopefully, the above proposed check will be implemented in the future before the automation check is enabled.
For OpenJ9 JDK22+, the following tests are disabled:
VThreadInHeapDumprelies upon-Xlog:heapdumpwhich is unsupported in OpenJ9.GetStackTraceAndRetransformTestutilizes theWhiteBoxAPI, which is also unsupported in OpenJ9.Closes: eclipse-openj9/openj9#18809
Closes: eclipse-openj9/openj9#18811