Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to set OPENJCEPLUS_GIT_REPO and BRANCH #5054

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Allow user to set OPENJCEPLUS_GIT_REPO and BRANCH #5054

merged 1 commit into from
Feb 12, 2024

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Feb 12, 2024 •
edited

resolves: #5055

@llxia
Copy link
Contributor Author

llxia commented Feb 12, 2024 •
edited

  • default values: link
  • OPENJCEPLUS_GIT_REPO is set link
00:01:41.967  getOpenJcePlusTests:
00:01:41.967       [exec] git clone --depth 1 -q https://github.com/llxia/OpenJCEPlus.git -b main OpenJCEPlus

@llxia llxia marked this pull request as ready for review February 12, 2024 18:19
@karianna
Copy link
Contributor

@llxia This fails because the newer upload artifact action doesn't allow the uploading of the exact same named artifact.

LongyuZhang
LongyuZhang approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
Copy link
Contributor Author

llxia commented Feb 12, 2024

PR builds failure has nothing to do with this PR. It is a known issue that PR builds do not check up PR repo: #4855. Even if it does, this PR cannot be tested via PR build.

@llxia
Allow user to set OPENJCEPLUS_GIT_REPO and BRANCH
9a4d166 
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia
Copy link
Contributor Author

llxia commented Feb 12, 2024

The PR is rebased.

@JasonFengJ9 JasonFengJ9 merged commit a590cfb into adoptium:master Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes

@LongyuZhang LongyuZhang LongyuZhang approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow user to set OPENJCEPLUS_GIT_REPO and BRANCH
4 participants
@llxia @karianna @JasonFengJ9 @LongyuZhang