-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LIGHT_WEIGHT_CHECKOUT error #5065
Conversation
sophiaxu0424
commented
Feb 14, 2024
- Fix: Rerun links should set LIGHT_WEIGHT_CHECKOUT=false #4841 about parameter LIGHT_WEIGHT_CHECKOUT error with personal forked branch.
- Jenkins build on grinder: https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/37960
Hi @llxia @LongyuZhang, would you please take a review for this PR, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sophiaxu0424 for working on this issue. However, your change is not correct.
We need to set LIGHT_WEIGHT_CHECKOUT to false for Grinder rerun link. Not changing the default value in TestJobTemplate.
Please see the following code as an example:
https://github.com/adoptium/aqa-tests/blob/master/buildenv/jenkins/JenkinsfileBase#L1180-L1183
2bf5b5f
to
3e74438
Compare
buildenv/jenkins/JenkinsfileBase
Outdated
// reset LIGHT_WEIGHT_CHECKOUT to false in Rerun in Grinder link | ||
if(lightWeightCheckout) { | ||
url = url.replace(lightWeightCheckout, "LIGHT_WEIGHT_CHECKOUT=false") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just do the following?
url = url.replace("LIGHT_WEIGHT_CHECKOUT=true", "LIGHT_WEIGHT_CHECKOUT=false")
Signed-off-by: sophiaxu0424 <xuminghong0424@gmail.com>
3e74438
to
80d1122
Compare
Thanks @sophiaxu0424 . Please run Grinder with LIGHT_WEIGHT_CHECKOUT=true. In the rerun in Grinder link, we should see LIGHT_WEIGHT_CHECKOUT=false. |
https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/38006/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM