Remove redundant non-capturing group special constructs #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping please. This is trivial. |
|
It is expected that the contributor will launch Grinder to verify the changes. See https://github.com/adoptium/aqa-tests/blob/master/Contributing.md |
|
Oh sorry. Sure! |
https://ci.adoptium.net/view/Test_grinder/job/Grinder/9865/ Checking on CryptoTests. I will try to elaborate if Ic an somehow run the jck. |
|
ok. all platforms passed. |
karianna
approved these changes
May 7, 2024
|
Thanks @judovana . The above Grinder tested CryptoTests. However, it is unsufficient for validating this PR as CryptoTests is disabled on all platforms anyway. The second test: internally tested. |
llxia
approved these changes
May 7, 2024
|
gosh. Ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm failing to see why there should be
?:construct in the platform matching regexes.it had to be some copypaste error in past. If I'm wrong, then I'm looking forward for info. Thanx!