Always Clean Workspace after build

[AdamBrousseau]

• Wrap all steps in try/finally.
• Move CleanWs to finally block.
• This ensures CleanWs always runs even if
  the build has failed a step.
• This also reverts Update cleanWS logic #320 which stopped the
  clean from running if the build failed.
• Proper archiving should ensure we don't need
  to leave workspaces around for test failure
  investigation.

Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com

[AdamBrousseau]

Marking as WIP to give time for discussion.
@llxia @sophia-guo @ShelleyLambert

[sophia-guo]

In general if test fails the build status is unstable. The fail status happens only when there is issue about jenkins step( or other wrapped command, or test exits unexpected). In those situation it would be easy to debug the issue if workspace is kept.

[AdamBrousseau]

I agree with your first 2 sentences. I'm not sure I see the value the workspace will provide in the cases where a test has failed hard. The situations I can think of when a hard failure will occur:

• Timeout
• Build aborted
• Machine config issue
• Network issue

Unless I'm missing a use case, I don't see the value in keeping or archiving the workspace in any of these. Maybe there's a case where a failed test will actually cause the test harness to fall over?

The issue I'm trying to solve is machines running out of space because test workspaces getting left behind.

[llxia]

I would suggest to have a flag added in finally block, so that we can turn on and off to fit different needs.

[AdamBrousseau]

Updated with KEEP_WORKSPACE