Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag static-libs artefact as such in metadata #194

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Sep 27, 2021

See also: adoptium/temurin-build#2699

Should get out of draft once/if adoptium/temurin-build#2725 gets merged.

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, but needs a full pipeline run

@jerboaa jerboaa marked this pull request as ready for review September 28, 2021 08:23
@jerboaa
Copy link
Contributor Author

jerboaa commented Sep 28, 2021

Seems OK, but needs a full pipeline run

@karianna Thanks. Can you explain what a "full pipeline run" means? Is that needed before or after this is integrated?

@karianna
Copy link
Contributor

Seems OK, but needs a full pipeline run

@karianna Thanks. Can you explain what a "full pipeline run" means? Is that needed before or after this is integrated?

I think it can go after - it's not harmful per se

@jerboaa jerboaa merged commit df113be into adoptium:master Oct 4, 2021
@sxa
Copy link
Member

sxa commented Oct 4, 2021

Seems OK, but needs a full pipeline run

@jerboaa I've just kicked off https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk11-pipeline/1677 so we'll be able to see the output of the jobs run from that run. If you can't see that first link, the individual jobs in https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/ are the ones that have the artefacts accessible in them at the end.

@jerboaa
Copy link
Contributor Author

jerboaa commented Oct 4, 2021

@sxa Thanks very much!

AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this pull request Jan 12, 2024
Bundle OpenJCEPlus and get GSKit binaries from Artifactory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants