Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct variant used for querying Temurin build jobs #264

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

andrew-m-leonard
Copy link
Contributor

getStatus method was changing variant from temurin to hotspot, thus the later build job query which searches based on "temurin" did not find any build jobs.

Signed-off-by: Andrew Leonard anleonar@redhat.com

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

@github-actions github-actions bot added code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts hotspot labels Mar 9, 2022
@andrew-m-leonard andrew-m-leonard self-assigned this Mar 9, 2022
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on the variable name, since I had to think about it for a second before I realised it was the TRSS API :-)

tools/nightly_build_and_test_stats.groovy Show resolved Hide resolved
@smlambert
Copy link
Contributor

Note (in case it affects how you have to handle updating this script) that we chose to leave the test names unchanged with this hotspot -> temurin rename in the build pipelines, to avoid downstream disruption (which is why this script is still able to retrieve test job info). If you are changing this script, there are temurin build names and temurin smoke test job names, but the main test pipelines continue to use the old naming schema.

@andrew-m-leonard
Copy link
Contributor Author

Note (in case it affects how you have to handle updating this script) that we chose to leave the test names unchanged with this hotspot -> temurin rename in the build pipelines, to avoid downstream disruption (which is why this script is still able to retrieve test job info). If you are changing this script, there are temurin build names and temurin smoke test job names, but the main test pipelines continue to use the old naming schema.

Yep, I noticed that. This just fixes the "build job" query.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit 126710f into adoptium:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts hotspot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants