Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rerunIterations #879

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Add rerunIterations #879

merged 1 commit into from
Jan 9, 2024

Conversation

smlambert
Copy link
Contributor

Fixes #777

Retry running certain test jobs automatically if they fail (wasteful if applied to unstable jobs that do not have up-to-date exclusions and triage done against them).

Signed-off-by: Shelley Lambert <slambert@gmail.com>
Copy link

github-actions bot commented Jan 9, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has been trialled with Semuru I'm going to assume this is safe so giving approval. A couple of notes:

  1. How does TRSS handle the re-runs?
  2. Since this is going to require regeneration for the new parameter it will presumably exacerbate "Skipped parameter" warnings in jenkins server log infrastructure#2774 in the short term until we get every job we have regenerated

@Haroon-Khel Haroon-Khel merged commit e910e9d into adoptium:master Jan 9, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trial the 'automatic rerun on failure' feature for test jobs
5 participants