Bugs in Windows Playbook found during regular deployment

[Haroon-Khel]

TASK [MSVS_2022 : Get SHA256 checksum of the file]

fatal: [build-azure-win2012r2-x64-4]: FAILED! => {"msg": "The conditional check '(vs2022_layout_ready.stat.exists ) and (windows_version.stdout_lines[0] | regex_search('^(10\\.|11\\.|2016|2019|2022)'))' failed. The error was: error while evaluating conditional ((vs2022_layout_ready.stat.exists ) and (windows_version.stdout_lines[0] | regex_search('^(10\\.|11\\.|2016|2019|2022)'))): 'dict object' has no attribute 'stat'\n\nThe error appears to be in '/tmp/awx_2108_g14r8155/project/ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/MSVS_2022/tasks/main.yml': line 34, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Get SHA256 checksum of the file\n  ^ here\n"}

Like #3244 the code for when msvs_2022 is not present needs to be put in its own block to make it easier for ansible to evaluate the when conditions ✅ fixed with #3248

TASK [MSVS_2022 : Transfer VS2022 Layout File] 

changed: [test-azure-win2016-x64-1] => {"changed": true, "checksum": "69f00c74e5634f3834caa4f11e499b2a381c12e4", "dest": "C:\\TEMP\\VS2022_Layout.zip", "failed_when_result": false, "msg": "failed to copy file /Vendor_Files/windows/vs_layout_2022.zip: Unhandled exception while executing module: There is not enough space on the disk.\r\n", "operation": "file_copy", "original_basename": "vs_layout_2022.zip", "size": 13810184523, "src": "/Vendor_Files/windows/vs_layout_2022.zip"}

No space left in disk when moving vs_layout_2022.zip onto machine. Affects test-azure-win2016-x64-1, test-azure-win2019-x64-1, build-ibmcloud-win2022-x64-1

TASK [MSVS_2022 : Register Visual Studio Community 2022 DIA SDK shared libraries]

failed: [test-azure-win11-aarch64-1] (item=C:\Program Files\Microsoft Visual Studio\2022\Community\DIA SDK\bin\msdia140.dll) => {"ansible_loop_var": "item", "changed": true, "cmd": "regsvr32 /s \"C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\DIA SDK\\bin\\msdia140.dll\"", "delta": "0:00:00.262765", "end": "2023-11-09 12:55:40.345830", "item": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\DIA SDK\\bin\\msdia140.dll", "msg": "non-zero return code", "rc": 3, "start": "2023-11-09 12:55:40.083065", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

Fails to register VS community 2022 libraries ✅ Fixed by manually installing msvs2022 on the machine. It was failing to install due to lack of space, and therefore the directories it is trying to register were not present

TASK [Java_install : Download Java16] 

fatal: [build-ibmcloud-win2012r2-x64-2]: FAILED! => {"changed": false, "dest": "C:\\temp\\jdk-16.zip", "elapsed": 0.0470005, "msg": "Error downloading 'https://api.adoptopenjdk.net/v3/binary/latest/16/ga/windows/x64/jdk/hotspot/normal/adoptopenjdk?project=jdk' to 'C:\\temp\\jdk-16.zip': The remote name could not be resolved: 'api.adoptopenjdk.net'", "status_code": null, "url": "https://api.adoptopenjdk.net/v3/binary/latest/16/ga/windows/x64/jdk/hotspot/normal/adoptopenjdk?project=jdk"}

build-ibmcloud-win2012r2-x64-2 is having trouble resolving api.adoptopenjdk.net

[Haroon-Khel]

Just to note, the install of MSVS2022 takes up quite a bit of space. The transfer of the VS2022_Layout.zip is 13G, when unzipped takes another 15G. The product to be installed is around 20g. The installed and unzipped directory are both removed after the install but during the install if the machine does not have the required space for all three of these things then the task fails

[sxa]

Just to note, the install of MSVS2022 takes up quite a bit of space. The transfer of the VS2022_Layout.zip is 13G, when unzipped takes another 15G. The product to be installed is around 20g. The installed and unzipped directory are both removed after the install but during the install if the machine does not have the required space for all three of these things then the task fails

That sounds like really good information to store somewhere. Maybe we could create a FAQ.md entry to document how much total space is required for a "base" playbook run on different OSs, starting with Windows and "before/after playbook" sizes?

I know it required around 100Gb previously (but of course for build purposes you need more space somewhere for the jenkins workspaces) so it would be good to know if that has gone up now.