Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windowsPb: Move msvs2022 install into own block #3248

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Nov 10, 2023

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Ref #3246 (comment)

The vs2022_layout_ready variable does not get registered when the Transfer VS2022 Layout File task is skipped (due to msvs2022 already being installed). Then when ansible tries to evaluate when: (vs2022_layout_ready.stat.exists) in the Get SHA256 checksum of the file task it hits an error:

TASK [MSVS_2022 : Get SHA256 checksum of the file]

fatal: [build-azure-win2012r2-x64-4]: FAILED! => {"msg": "The conditional check '(vs2022_layout_ready.stat.exists ) and (windows_version.stdout_lines[0] | regex_search('^(10\\.|11\\.|2016|2019|2022)'))' failed. The error was: error while evaluating conditional ((vs2022_layout_ready.stat.exists ) and (windows_version.stdout_lines[0] | regex_search('^(10\\.|11\\.|2016|2019|2022)'))): 'dict object' has no attribute 'stat'\n\nThe error appears to be in '/tmp/awx_2108_g14r8155/project/ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/MSVS_2022/tasks/main.yml': line 34, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Get SHA256 checksum of the file\n  ^ here\n"}

Moving the install code into its own block should fix this like it did with #3244

@Haroon-Khel
Copy link
Contributor Author

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit 41cb386 into adoptium:master Nov 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants