Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable new fqcn ansible-lint rule #2522

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented Apr 6, 2022

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@zdtsw
Copy link
Contributor Author

zdtsw commented Apr 6, 2022

@Haroon-Khel could this be something relate to what you mentioned?

@zdtsw
Copy link
Contributor Author

zdtsw commented Apr 7, 2022

@sxa could you do a review on this change? ansible-lint should be fixed

@Haroon-Khel
Copy link
Contributor

I think this might fix some of the errors I am getting on this pr https://github.com/adoptium/infrastructure/runs/5602971970?check_suite_focus=true

Error: fqcn-builtins Use FQCN for builtin actions.
Error: fqcn-builtins Use FQCN for builtin actions.
Error: fqcn-builtins Use FQCN for builtin actions.

@zdtsw
Copy link
Contributor Author

zdtsw commented Apr 7, 2022

created a new issue #2524 for failure in ansible /macos

@sxa sxa requested a review from Haroon-Khel April 8, 2022 08:59
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this on the basis it now passes the linker, but I've requested Haroon as a reviewer too since the DockerStatic role handler affects a change he recently put in.

@zdtsw
Copy link
Contributor Author

zdtsw commented Apr 8, 2022

Copy link
Contributor

@Haroon-Khel Haroon-Khel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dockerstatic changes look good to me 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants