-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable new fqcn ansible-lint rule #2522
Conversation
@Haroon-Khel could this be something relate to what you mentioned? |
@sxa could you do a review on this change? ansible-lint should be fixed |
I think this might fix some of the errors I am getting on this pr https://github.com/adoptium/infrastructure/runs/5602971970?check_suite_focus=true
|
created a new issue #2524 for failure in ansible /macos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this on the basis it now passes the linker, but I've requested Haroon as a reviewer too since the DockerStatic role handler affects a change he recently put in.
changes made in DockerStatic/tasks/main.yml ref: https://ansible-lint.readthedocs.io/en/latest/default_rules/#no-handler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dockerstatic changes look good to me 👍🏻
Checklist