ansible: Remove jinja name template errors #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stewart X Addison <sxa@redhat.com>
9 tasks
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Haroon-Khel
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a number of instances where this policy of requiring jinja templates in
name:clauses does not make sense e.g. when a path name is used (e.g./home/{{ Jenkins_User }}/somedir) and I have not seen a compelling reason for this to be enforced, therefore I propose disabling it.Ref: https://ansible-lint.readthedocs.io/rules/name/
Similarly when running the checks on this PR it was noticed that there is another error showing up in some of the rules. The second commit in skips that one too (I tried moving to warn_list: as per the snippet below but that didn't seem to work and it still showed as an error). Removal of this as an error is consistent with the comments made upstream in ansible/ansible-lint#2512
Signed-off-by: Stewart X Addison sxa@redhat.com
Checklist