Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: Add perl-IPC-Cmd to Redhat/CentOS installs for OpenSSL v3 #3014

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

pshipton
Copy link
Contributor

@pshipton pshipton commented Apr 3, 2023

These were added in #2855 but in the wrong place. perl-IPC-Cmd is required for all platforms.

Checklist

compile

* compiling openssl v3 within container or system requires this package
* see eclipse-openj9/openj9#14930

These were added in adoptium#2855
but in the wrong place. perl-IPC-Cmd is required for all platforms.

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Contributor Author

pshipton commented Apr 3, 2023

@sxa can you pls help with the review and testing on this.

@sxa
Copy link
Member

sxa commented Apr 3, 2023

@sxa can you pls help with the review and testing on this.

VPC run on JDK17/J9: https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1659/

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it passes testing

@sxa
Copy link
Member

sxa commented Apr 4, 2023

Tests failed due to adoptium/temurin-build#3252 (Freemarker download failing) but since that has now been removed from the default options in OpenJ9's build process we should likely do the same ...

@pshipton
Copy link
Contributor Author

pshipton commented Apr 4, 2023

Is that going to block merging this? I can look at removing freemarker in another PR if that helps, searching for references to freemarker and deleting it all.

@sxa
Copy link
Member

sxa commented Apr 4, 2023

Is that going to block merging this? I can look at removing freemarker in another PR if that helps, searching for references to freemarker and deleting it all.

Stay tuned :-) I'm running another test with a branch that should disable it at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1660/

@sxa
Copy link
Member

sxa commented Apr 4, 2023

Interesting - got a memory exhausted error on Debian 10 and it was unable to find nasm when configuring the build on Ubuntu 20.04, but CentOS 8 was happy so hopefully the others will be ok too.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - CentOS 6 and 7 worked ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants