Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnixPB : Linter Fixes #3111

Merged
merged 10 commits into from
Jun 21, 2023
Merged

UnixPB : Linter Fixes #3111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
32d434c
Update become method to be fq.
steelhead31 Jun 21, 2023
adcf163
Add ansible lint rule for variables file.
steelhead31 Jun 21, 2023
d0ed202
fix yml
steelhead31 Jun 21, 2023
9681d17
Delete ansible-lint test
steelhead31 Jun 21, 2023
d144ddd
Test lint fix
steelhead31 Jun 21, 2023
60320bd
Specify linter to use on variables file
steelhead31 Jun 21, 2023
655a87e
Fix spacing
steelhead31 Jun 21, 2023
0c76453
Specify vars schema for adoptopenjdk vars file
steelhead31 Jun 21, 2023
a5069c9
revert sudo change
steelhead31 Jun 21, 2023
17bbe28
Fix sudo to be fq name.
steelhead31 Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .ansible-lint
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
---
# .ansible-lint

skip_list:
- '106' # Role name {} does not match ``^[a-z][a-z0-9_]+$`` pattern
- '204' # Lines should be no longer than 160 chars
Expand All @@ -22,6 +24,8 @@ skip_list:
- 'fqcn[action]' # Exclude As Requires Significant Changes ( 249 changes required )
- 'args[module]' # Exclude Experimental Rule Validation ( Prevents 4 experimental warnings )

kinds:
- vars: "ansible/playbooks/adoptopenjdk_variables.yml"

exclude_paths:
- ./ansible/playbooks/adoptopenjdk_variables.yml # See: https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1926
- ansible/playbooks/adoptopenjdk_variables.yml # See: https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1926
2 changes: 1 addition & 1 deletion ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/adoptopenjdk_install/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@
group: wheel
become: yes
become_user: root
become_method: sudo
become_method: ansible.builtin.sudo

- name: Install latest JDK {{ jdk_version }} release if one not already installed (Solaris)
when:
Expand Down
Loading