Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowsPB: Include Checksum Verification of VS2019 Layout #3175

Merged
merged 5 commits into from
Sep 5, 2023
Merged

WindowsPB: Include Checksum Verification of VS2019 Layout #3175

merged 5 commits into from
Sep 5, 2023

Conversation

steelhead31
Copy link
Contributor

Fixes #3166

Checklist

@steelhead31
Add VS2022 installation
d30f51d
@steelhead31
Add checksum verification
f5d2eb0 
Add checksum verification for VS2019 layout
@steelhead31
Copy link
Contributor Author

steelhead31 commented Sep 1, 2023 •
edited
Loading

Runs ok on windows server 2022, VPC check in progress on https://ci.adoptium.net/job/VagrantPlaybookCheck/1708/

@steelhead31 steelhead31 marked this pull request as ready for review September 4, 2023 07:24
@steelhead31
Copy link
Contributor Author

VPC looks good, moving to review ready.

@steelhead31
Update main.yml
cd02630 
Correct checksum
@karianna
Copy link
Contributor

karianna commented Sep 4, 2023

@steelhead31 I assume the failed GH Action is the thing that'll get fixed by this?

@steelhead31
Copy link
Contributor Author

@steelhead31 I assume the failed GH Action is the thing that'll get fixed by this?

Im afraid not, the GitHub action relates to something to do with the DLL registration for VS2017, I can't replicate that issue to figure out how to fix it though...

@steelhead31
Copy link
Contributor Author

@karianna I've picked up issue #3106 to try and see if I can find the underlying cause/solution to the Github Action failing.

@steelhead31 steelhead31 merged commit f081d33 into adoptium:master Sep 5, 2023
7 of 8 checks passed
@steelhead31 steelhead31 deleted the fix_issue_3166b branch September 5, 2023 12:32
@sxa sxa added this to the 2023-09 (September) milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@Haroon-Khel Haroon-Khel Haroon-Khel approved these changes

Assignees
No one assigned
Labels
ansible
Projects
None yet
Milestone
2023-09 (September)
Development

Successfully merging this pull request may close these issues.

WindowsPB: Add Checksum Verification For VS2019 layout
5 participants
@steelhead31 @karianna @gdams @Haroon-Khel @sxa