WinPB: Fix VS2017 Github Action On Win2022 #3176

steelhead31 · 2023-09-05T08:09:59Z

Trying some fixes for the VS2017 dll registration during the github action for Win2022, this does not occur in vagrant, or on Windows VMs..

Checklist

commit message has one of the standard prefixes
faq.md updated if appropriate
other documentation is changed or added (if applicable)
playbook changes run through VPC or QPC (if you have access)
VPC/QPC not applicable for this PR
for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Try unregister vs2017 dlls Test registration with install switches. Restore defaults Try VS install switches fix Skip vs2017 role Test for DLL exists before register test. Test logged install Switch to full install. Test vs2017 install via powershell Test alt install cmd Fix DLL conditional check. Remove rogue file.

…structure into fix_vs2017_gha

steelhead31 · 2023-09-06T08:36:55Z

The parameter change to use --passive rather than --quiet causes the playbook to fail, when the download and install of VS2017 fails for any reason, --quiet prevents an error code, thus causing the issue with DLL registration.

steelhead31 · 2023-09-06T10:29:24Z

Having done a large amount of investigation, this PR is not required, the problem installing VS2017 is tied to the github runner image for windows-2022 already containing VS2022, its not possible to install VS2017 once VS2022 has been installed.

github-actions bot added ansible ghActions GitHub Actions and removed ansible ghActions GitHub Actions labels Sep 5, 2023

steelhead31 force-pushed the fix_vs2017_gha branch from 5f85c36 to f5794f2 Compare September 5, 2023 20:16

github-actions bot added ghActions GitHub Actions and removed ghActions GitHub Actions labels Sep 5, 2023

steelhead31 force-pushed the fix_vs2017_gha branch from bab65b3 to cb1ccf0 Compare September 6, 2023 07:31