Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update docs to include deleting docker static containers #3562

Closed
wants to merge 2 commits into from
Closed

docs: Update docs to include deleting docker static containers #3562

wants to merge 2 commits into from

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented May 13, 2024 •
edited
Loading

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Update docs for #3561

@Haroon-Khel Haroon-Khel mentioned this pull request May 13, 2024
Merged
6 tasks
@karianna
Copy link
Contributor

Mighty be worth both upgrading semgrep and fixing its complaint :-)

@steelhead31
Copy link
Contributor

steelhead31 commented May 14, 2024 •
edited
Loading

@Haroon-Khel / @karianna  I'll upgrade semgrep, Im just making a change to add the license text to the 3 action files I added :) PR for the semgrep upgrade: adoptium/.github#127

@steelhead31
Copy link
Contributor

Semgrep action is now correct, however the release of semgrep from a week ago, hasn't yet been reflected into the containers. Coming soon I believe :)

@Haroon-Khel Haroon-Khel mentioned this pull request May 14, 2024
Closed
steelhead31
steelhead31 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, semgrep flag is false positive, as the docker command is just an example in documentation

@Haroon-Khel
Copy link
Contributor Author

The changes of this pr are going in with #3561. So this pr can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@steelhead31 steelhead31 steelhead31 approved these changes

@sxa sxa Awaiting requested review from sxa

Assignees
No one assigned
Labels
ansible doc docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Haroon-Khel @karianna @steelhead31