Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: Add docker buildx functionality to dockernode playbook for arm32 containers #3601

Merged
merged 8 commits into from
Jun 20, 2024
Merged

docker: Add docker buildx functionality to dockernode playbook for arm32 containers #3601

merged 8 commits into from
Jun 20, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Jun 14, 2024 •
edited
Loading

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Ref #3579

Adds ability to build arm32 containers using docker buildx. Updates docs accordingly

sxa
sxa reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this has been tested with the latest changes LGTM to me.

@Haroon-Khel
Copy link
Contributor Author

Assuming this has been tested with the latest changes LGTM to me.

Yes the latest changes have been tested 👍🏻

steelhead31
steelhead31 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Haroon-Khel Haroon-Khel requested a review from sxa June 18, 2024 15:23
sxa
sxa approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies - I thought my last comment included an approval.

@Haroon-Khel Haroon-Khel merged commit 8fc8be4 into adoptium:master Jun 20, 2024
9 of 12 checks passed
@Haroon-Khel Haroon-Khel deleted the arm32.dockernode branch June 20, 2024 09:25
@Haroon-Khel Haroon-Khel mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa approved these changes

@steelhead31 steelhead31 steelhead31 approved these changes

@karianna karianna Awaiting requested review from karianna

Assignees
No one assigned
Labels
ansible arch:arm32 doc docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Haroon-Khel @karianna @sxa @steelhead31