-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please provide the java -version output of a nightly build on the nightly build download page #367
Comments
Also see #264 |
Note that OpenJDK 11 and later also support |
@johnoliver can this functionality be added to the v3 API? |
@karianna Can this be transferred to the API Repo? |
I'm not sure the original ask makes sense? Is the user try to tie back to an actual source code commit? I think we could provide that in the meta data |
The OP of this has retired so it's possible he was before he left. We could just close this for now and reopen/link to it if someone else has this request? Either way, I feel like this is something for the website or API team to deal with, not build. |
@M-Davies I disagree, the only way to provide the java -version output to the API would be to add it to the JSON metadata. |
We produce a version.txt after each build. If we added that to the JSON metadata, would that suffice? |
yes it should just be a case of adding that to the JSON metadata and then we can parse it in the API. There have also been separate requests to add the openjdk-build git sha and openjdk-jdku git sha to the metadata. |
@gdams @karianna I'd like to get your opinion on two ideas for this
|
I'm personally leaning toward option 2. |
I'm not convinced I can do that one anymore. We setup the version info class while the pipeline is still on the slave machine but we don't use the metadata one until we hit the master node, where the |
OK, so version 1 it is then :-) |
Raised https://github.com/AdoptOpenJDK/openjdk-website/issues/739 to follow this up on the website side |
Please provide the java -version output of each build on the download so users can track it
back to a git branch and commit. The "Checksum", i.e.
b909a21222813fbba0c2484ce33e1c63a503f556ba78a1466a018e41d9514217 OpenJDK10-OPENJ9_x64_Win_20180611.zip
doesn't appear to correspond to a commit in the OpenJ9 repo on github, nor in the AdoptOpenJDK repo.
The text was updated successfully, but these errors were encountered: