Skip to content
This repository has been archived by the owner on Oct 14, 2021. It is now read-only.

Add java -version output to the nightly build download page #236

Closed
M-Davies opened this issue Jun 23, 2020 · 14 comments
Closed

Add java -version output to the nightly build download page #236

M-Davies opened this issue Jun 23, 2020 · 14 comments
Assignees
Labels
enhancement New feature or request good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed help wanted Extra attention is needed

Comments

@M-Davies
Copy link
Contributor

See adoptium/temurin-build#367

We are now adding the java version output to the metadata from the builds. Assuming this will now automatically appear in the API (CC @johnoliver ?), please provide the java -version output of each build on the download so users can track it back to a git branch and commit.

@gdams
Copy link
Member

gdams commented Jun 23, 2020

I think the API might need some changes to expose this, lets see what @johnoliver thinks

@johnoliver
Copy link
Member

I am not sure what is in the java -version output that is not in the version data
looking at

{
    "WARNING": "THIS METADATA FILE IS STILL IN ALPHA DO NOT USE ME",
    "os": "linux",
    "arch": "x64",
    "variant": "hotspot",
    "version": {
        "minor": 0,
        "full_version_output": "openjdk version \"11.0.8\" 2020-07-14\nOpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+5-202006222334)\nOpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.8+5-202006222334, mixed mode)\n",
        "security": 8,
        "pre": null,
        "adopt_build_number": 0,
        "major": 11,
        "version": "11.0.8+5-202006222334",
        "semver": "11.0.8+5.0.202006222334",
        "build": 5,
        "opt": "202006222334",
  },
    "scmRef": "",
    "version_data": "jdk11u",
    "binary_type": "jdk",
    "sha256": "dbc32955fc283989f57ef832f3398af0cc7de7b9287256077206bb6e023dc693"
}

It seems like all the data in the full_version_output is also in version

@M-Davies
Copy link
Contributor Author

It was requested at adoptium/temurin-build#367 that the version output is displayed at the nightly download page

@johnoliver
Copy link
Member

I think the problem is that issue was requesting this to tie back a build to a git commit, I am not sure the output of java -version here allows you to do that. I would have thought a way to do this would be to include the git commit hash into the metadata

@M-Davies
Copy link
Contributor Author

@johnoliver See existing issue for that adoptium/temurin-build#474

@johnoliver
Copy link
Member

@M-Davies yeah I think that would be the issue to solve as I think that would solve adoptium/temurin-build#367 but I dont believe adding java -version to the metadata does

@M-Davies
Copy link
Contributor Author

M-Davies commented Jul 7, 2020

See adoptium/temurin-build#1959

@M-Davies
Copy link
Contributor Author

M-Davies commented Jul 8, 2020

Transferring to api repo (see #235 (comment))

@M-Davies M-Davies transferred this issue from AdoptOpenJDK/openjdk-website Jul 8, 2020
@karianna karianna added this to To do in openjdk-api-v3 via automation Jul 8, 2020
@karianna karianna added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 8, 2020
@johnoliver
Copy link
Member

we are going to look at adding a link to the metadata file into the api on the Asset, so if the web page wants the version output it can pull that data via that link

@nickebbitt
Copy link
Contributor

I've started looking at this

@karianna karianna moved this from To do to In progress in openjdk-api-v3 Jul 17, 2020
@karianna karianna added this to the July 2020 milestone Jul 17, 2020
@karianna karianna modified the milestones: July 2020, August 2020 Aug 2, 2020
@M-Davies
Copy link
Contributor Author

M-Davies commented Aug 3, 2020

@nickebbitt Can this be closed?

@karianna karianna added this to To do in Good First Issues Aug 7, 2020
@nickebbitt
Copy link
Contributor

@karianna this now live so can be closed

@M-Davies
Copy link
Contributor Author

M-Davies commented Sep 6, 2020

See #235 (comment)

@karianna
Copy link
Member

karianna commented Sep 8, 2020

Opened a website issue for this

@karianna karianna closed this as completed Sep 8, 2020
openjdk-api-v3 automation moved this from In progress to Done Sep 8, 2020
Good First Issues automation moved this from In progress to Done Sep 8, 2020
@hendrikebbers hendrikebbers added the good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed label Sep 21, 2020
@hendrikebbers hendrikebbers removed the good first issue Good for newcomers label Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed help wanted Extra attention is needed
Projects
Development

No branches or pull requests

6 participants