Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable correct codesigning on jdk11 #1463

Merged
merged 7 commits into from
Jan 24, 2020
Merged

enable correct codesigning on jdk11 #1463

merged 7 commits into from
Jan 24, 2020

Conversation

gdams
Copy link
Member

@gdams gdams commented Jan 9, 2020 •
edited

uses the built in codesign args defined in AdoptOpenJDK/openjdk-jdk11u@b3250ad

@johnoliver
Copy link
Contributor

run tests

2 similar comments
@johnoliver
Copy link
Contributor

run tests

@johnoliver
Copy link
Contributor

run tests

@gdams gdams force-pushed the codesign branch 3 times, most recently from 85d2e6f to 2a0e1b9 Compare January 23, 2020 17:52
@gdams
Copy link
Member Author

gdams commented Jan 23, 2020 •
edited

Hotspot Build: https://ci.adoptopenjdk.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk11u/job/jdk11u-mac-x64-hotspot/32/ => codesign-report

OpenJ9 Build: https://ci.adoptopenjdk.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk11u/job/jdk11u-mac-x64-openj9/4/ => codesign report

@gdams
Copy link
Member Author

gdams commented Jan 23, 2020

@johnoliver this is good to go now, there's some changes required in the OpenJ9 source code to sign the remaining .dylib files but this is all good to go on our end!

@gdams gdams requested a review from johnoliver January 23, 2020 20:18
@johnoliver johnoliver merged commit 20bb009 into adoptium:master Jan 24, 2020
@gdams gdams deleted the codesign branch January 24, 2020 14:22
@karianna karianna added the bug Issues that are problems in the code as reported by the community label Jan 26, 2020
@karianna karianna added this to TODO in temurin-build via automation Jan 26, 2020
@karianna karianna added this to the January 2020 milestone Jan 26, 2020
@karianna karianna moved this from TODO to Done in temurin-build Jan 26, 2020
@Willsparker Willsparker mentioned this pull request Jan 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnoliver johnoliver Awaiting requested review from johnoliver

Assignees
No one assigned
Labels
bug Issues that are problems in the code as reported by the community
Projects
No open projects
temurin-build
  
Done
Milestone
January 2020
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gdams @johnoliver @karianna