Cleanup excessive linter checks #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commiters have identified that the super linter checks are excessively strict, so this pr attempts to summarise and eliminate checks that appear non-blocking to the Adoptium community Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
M-Davies
added
bug
* They're mostly to do with how the build template is lain out which doesn't matter as values get replaced when it is executed Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
A lot of these are simple changes but the rules that were flagged are valid issues imo (the only one not being so is MD029 which is handled automatically by github so there is no need to enforce it) Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
This file is modified by build.sh so it shouldn't really be linted Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
* This allows us to exclude and configure linter rules
* This is warning us about code clones in the test files which are not actually clones as they implement different parameters Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
* Common standards are to include a comment on why they have been disabled Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
* Tabs and spaces generally do the same thing Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
* Spawned an issue to address seperatly
* Hasn't been touched in 3 years * Generating lots of errors
karianna
approved these changes
May 5, 2021
|
@karianna Can you merge? |
smlambert
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commiters have identified that the super linter checks are excessively strict, so this pr attempts to summarise and eliminate checks that appear non-blocking to the Adoptium community
Fixes: #2581
Signed-off-by: Morgan Davies morgandavies2020@gmail.com