When auto-downloading boot JDK, default to hotspot (Don't use temurin in API) #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in API) Signed-off-by: Stewart X Addison <sxa@redhat.com>
github-actions
bot
added
alpine-linux
|
ping @AdamBrousseau I don't think this will negatively affect you (for production levels we should have them on the machine already, and the APIs won't download the latest Semeru anyway), but if you believe otherwise let me know. |
AdamBrousseau
approved these changes
Feb 15, 2022
andrew-m-leonard
approved these changes
Feb 15, 2022
|
@sxa worth checking with Alibaba? |
Dragonwell is not available through the Adopt API so this will not affect them, but it's needed for Temurin JDK19 builds to succeed. |
|
NOTE: The Dragonwell boot JDK issue that lead to the previous two comments is referred to in #2353 |
SehrishHussain
pushed a commit
to SehrishHussain/temurin-build
that referenced
this pull request
Mar 1, 2022
… in API) (adoptium#2853) Signed-off-by: Stewart X Addison <sxa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't believe this will adversely affect anyone any more, so hard coding this in light of the changes made in #2818 so that the API call does not try to use
temurinAlternate solution would be to use a bash specific construct of
${VARIANT/temurin/hotspot}(Causes JDK19 to fail to build as it won't be able to download a boot JDK and we don't install that one via the playbooks yet as it's not a GA level)
Signed-off-by: Stewart X Addison sxa@redhat.com