release file in root of JDK8 tarball should have JVM_VARIANT=Hotspot
#2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxa
force-pushed
the
jdk8_releasefile_variant
branch
from
a700073
to
dc6b79a
Compare
sxa
changed the title
JVM_VARIANT=Hotspotrelease file in root of tarball should have JVM_VARIANT=Hotspot
sxa
changed the title
release file in root of tarball should have JVM_VARIANT=Hotspotrelease file in root of JDK8 tarball should have JVM_VARIANT=Hotspot
sxa
force-pushed
the
jdk8_releasefile_variant
branch
from
dc6b79a
to
f844b47
Compare
|
Check failures look like connection issues and unrelated to this PR |
|
@sxa is |
This is consistent with how it was in our previous GAs, so unless we have a desire to change it it is correct. |
|
(Forced reruns of checks) |
Signed-off-by: Stewart X Addison <sxa@redhat.com>
sxa
force-pushed
the
jdk8_releasefile_variant
branch
from
f844b47
to
ebb4706
Compare
andrew-m-leonard
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently has
JVM_VARIANT="Temurin"which is not what we want.Fixes #2862