Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mac Build JDK From SBOM script #3812

Merged
merged 23 commits into from
May 17, 2024
Merged

Add Mac Build JDK From SBOM script #3812

merged 23 commits into from
May 17, 2024

Conversation

steelhead31
Copy link
Contributor

Fixes #3633

Has been tested extensively as a standalone script: sample output:

Comparing src_jdk/Contents/Home with tar_jdk/Contents/Home ... output to file: repro_diff.out
Number of differences:      154
ReproduciblePercent = 99.85 %

@github-actions github-actions bot added the testing Issues that enhance or fix our test suites label May 15, 2024
@steelhead31
Copy link
Contributor Author

This script is the mac equivalent of the windows script :)

karianna
karianna approved these changes May 16, 2024
View reviewed changes
tooling/reproducible/macos_repro_build_compare.sh Outdated Show resolved Hide resolved
tooling/reproducible/macos_repro_build_compare.sh Outdated Show resolved Hide resolved
tooling/reproducible/macos_repro_build_compare.sh Outdated Show resolved Hide resolved
tooling/reproducible/macos_repro_build_compare.sh Show resolved Hide resolved
steelhead31 and others added 3 commits May 16, 2024 10:48
@steelhead31 @karianna
Update tooling/reproducible/macos_repro_build_compare.sh
4c86815 
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
@steelhead31 @karianna
Update tooling/reproducible/macos_repro_build_compare.sh
2ab0a99 
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
@steelhead31
Trim target file name. And whitespace fixes
5bf8bb5
@sophia-guo
Copy link
Contributor

Since there are common functions for Mac and Window ( could also work for linux?), might be worth to restructure and integrate them to a common file later.

andrew-m-leonard
andrew-m-leonard approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@steelhead31 steelhead31 merged commit c09349a into adoptium:master May 17, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

@sophia-guo sophia-guo Awaiting requested review from sophia-guo

@karianna karianna Awaiting requested review from karianna

Assignees
No one assigned
Labels
testing Issues that enhance or fix our test suites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Mac support for building from SBOM script
4 participants
@steelhead31 @sophia-guo @karianna @andrew-m-leonard