Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision Drivers / Forces #93

Closed
mmadson opened this issue Mar 29, 2023 · 5 comments · Fixed by #96
Closed

Decision Drivers / Forces #93

mmadson opened this issue Mar 29, 2023 · 5 comments · Fixed by #96

Comments

@mmadson
Copy link

mmadson commented Mar 29, 2023

What happened to them? I don't see a discussion about their removal in either the changelog or adrs. I always found them to be the most important part of the template.

@koppor
Copy link
Member

koppor commented Apr 3, 2023

What do you mean by the slash in "Decision Drivers / Forces"?

I open https://github.com/adr/madr/blob/main/template/adr-template.md

I see "Decision Drivers":

image

I open https://github.com/adr/madr/blob/main/docs/decisions/adr-template.md

I see "Decision Drivers":

image

Please provide me a step-by-step introduction where exactly you miss "Decision Drivers"!

@mmadson
Copy link
Author

mmadson commented Apr 3, 2023

Hey there,

What I meant by the slash between drivers and forces was a synonym. I've heard decision drivers referred to as decision forces in the past, however it doesn't seem like either decision drivers or decision forces are currently documented on the published madr website. I'm relieved to hear they are still part of the actual template but without any documentation to reinforce their use, I fear people may argue they are not actually part of the spec.

To confirm you can go to https://adr.github.io/madr/ and https://adr.github.io/madr/examples.html and search for either the keyword "driver" or "force" and you will observe it does not appear anywhere on the published site, not even in the "long version example", leading me to believe the section was removed or deprecated.

@koppor
Copy link
Member

koppor commented Apr 3, 2023

To confirm you can go to adr.github.io/madr and adr.github.io/madr/examples.html and search for either the keyword "driver" or "force" and you will observe it does not appear anywhere on the published site, not even in the "long version example", leading me to believe the section was removed or deprecated.

Thank you for the hint. You are welcome to submit another example.

I keep this issue open until this is solved.

I fully agree, we should work on the homepage. However, we currently don't find time to do that.

Nitpick: We used "longer" than "full" to indicate there is even more to put in:

image

Nothing prevents you to start from adr-template.md.

Other interesting thing: At https://web.archive.org/web/20201101000000*/https://adr.github.io/madr one can browse through different incarnations of the homepage. - Ah, and I see that the old homepage provided the full template - https://web.archive.org/web/20201128000936/https://adr.github.io/madr/.

image

I remember that the reason to remove the full template was its length.

Think, we should re-add it to have the main page concise and to prevent users to be puzzled about two places to look at the template.

@mmadson
Copy link
Author

mmadson commented Apr 4, 2023

Got it, understood. If there is a way I can help the community please do let me know. We were very puzzled when we were quickly searching the main page and couldn't find the decision drivers when showing MADRs to a new engineer. It's a super helpful aspect of the template in our opinion and would love to see it return to the main page in some fashion. Regardless glad to know about the underlying template in the repo. Will point to that for now.

@koppor
Copy link
Member

koppor commented Apr 4, 2023

Thank you for your patience. I created a quick fix at #96.

It displays the development version now at the homepage. Manually keeping the template up-to-date on the homepage lead to errors here. Maybe, it is also in the spirit of "release early, release often" to get early feedback of the community.

Screenshot:

image

Hope, this solves the issue in an (at least) OKish way 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants