-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ability to disable vertical alignment for condition symbol #115
Comments
Nice work... as soon I get my hands back to my macbook I will look at your PRs... |
@bertrandmartel ok, as soon you describe the new functionalities in the readme and in the gh-page with an example (https://github.com/adrai/flowchart.js/blob/gh-pages/index.html) or at least a proposal... ;-) I will merge the PRs |
I've added in the readme
I've updated gh-pages locsize demo with more aligned conditions. Is that ok or you prefer to setup a new demo ? |
@adrai Also do you want me to commit the |
It's ok, I will do the rest... 😉 |
I came across this PR and the issue it solves today by chance through a post on StackOverflow. I'm just curious, why not make this the default for diagrams created with flowchart.js? It seems to me that flowcharts look a lot better when parallel items are not scattered all over the place but kept in one column. |
Implement ConditionNode alignment support (#14). This comment follows bertrandmartel's steps (adrai/flowchart.js#115 (comment)): 1. add ability to put parameters for Node declaration such as: element(param1=value1,param2=value2)=>start: Start * add Node.params field, a dict for params; * add Node.set_param() method to set params; * modify Node.fc_definition to write params into generated flowchart. 2. add ability to set `align-next=no` param for ConditionNode: * add ConditionNode.no_align_next() to set the param. * ConditionNode.__init__() support passing a `align_next=False` to set it. Closes #14
I've noticed that when multiple elements are aligned the upper condition element is aligning to the left of the bottom right hand element. For example, I have this configuration
You can reproduce with
I've forked and modified the library to add ability to put parameters for symbol declaration such as
This is done using
In flowchart.symbol.condition I identified the code responsible for identifying if an element is under this one : here
After applying the new configuration which indicates not to vertical align the next element
It gives
What do you think about this ?
The text was updated successfully, but these errors were encountered: